[2.0.0-dev1] Avoid re-using boost::flat_map::iterator after emplace as it is invalidated.
#1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
changed the title
boost::flat_map::iterator after emplace as it is invalidated.boost::flat_map::iterator after emplace as it is invalidated.
|
This doesn't seem like it needs to go to dev1? I mean no reason it can't but seems unnecessary |
Maybe I misunderstood, I thought @arhag suggested I add the fix here as well in case a new protocol feature gets added. Was it another branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge fix for issue #1811.
Probably happens only in
2.0because we have 2+ protocol features depending on thesavannadependency (causing the flat_map to resize when processing the firstsavannadependency, so somesavannadependencies are incorrectly not marked astrue, and when processing additional features depending onsavannait fails.