Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0 cleos cannot handle reponses from pre-5.0 nodes containing base64 (and vice versa I believe) #1883

Closed
spoonincode opened this issue Nov 9, 2023 · 1 comment · Fixed by #1886 or #1891
Closed

5.0 cleos cannot handle reponses from pre-5.0 nodes containing base64 (and vice versa I believe) #1883

spoonincode opened this issue Nov 9, 2023 · 1 comment · Fixed by #1886 or #1891
Assignees
@heifner
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v3.2.5

Comments

@spoonincode
Copy link
Member

There appears to be an incompatibility introduced with #1482 where a 5.0 cleos is unable to decode base64 responses from a pre-5.0 nodeos containing the invalid = postfix. I believe this might also might be broken in the other direction too (a pre-5.0 cleos being unable to decode a 5.0 response).

The easiest way to reproduce the problem is via cleos get code eosio.token on EOS mainnet; it currently exhibits the problem.
@spoonincode spoonincode added the bug Something isn't working label Nov 9, 2023
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 9, 2023
@bhazzard
Copy link

bhazzard commented Nov 9, 2023

Create backport patches applying #1482 to 3.2, and 4.0.

Ensure this underlying code doesn't impact consensus (we believe its caused by an issue with line 493 of fc::variant)

@bhazzard bhazzard added this to the Leap v3.2.5 milestone Nov 9, 2023
@bhazzard bhazzard added 👍 lgtm and removed triage labels Nov 9, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Nov 9, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Nov 9, 2023
@heifner heifner mentioned this issue Nov 10, 2023
Merged
@heifner heifner linked a pull request Nov 10, 2023 that will close this issue
[5.0] Revert "Fix base64 encoding" #1886
Merged
heifner added a commit that referenced this issue Nov 13, 2023
@heifner
Merge pull request #1886 from AntelopeIO/GH-1883-base64-rm-5.0
de71459 
[5.0] Revert "Fix base64 encoding"
heifner added a commit that referenced this issue Nov 13, 2023
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-1883-base64…
72101c4 
…-rm-main
@heifner heifner mentioned this issue Nov 13, 2023
Merged
heifner added a commit that referenced this issue Nov 13, 2023
@heifner
Merge pull request #1891 from AntelopeIO/GH-1883-base64-rm-main
680780d 
[5.0 -> main] Revert "Fix base64 encoding"
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v3.2.5
4 participants
@bhazzard @heifner @spoonincode @enf-ci-bot