ship updates: update finality_data to 1.0.0 layout; add block_header_extension (as added in 1.0.2)
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 17, 2024
spoonincode
commented
Sep 17, 2024
include/eosio/ship_protocol.hpp
Outdated
| EOSIO_REFLECT(proposer_policy_diff, version, proposal_time, remove_indexes, insert_indexes) | ||
|
|
||
| struct finality_extension { | ||
| qc_claim qc_claim = {}; |
Contributor
Author
There was a problem hiding this comment.
whoops I should have remembered gcc does not like that
Contributor
There was a problem hiding this comment.
Annoying that gcc trips over those.
linh2931
approved these changes
Sep 23, 2024
Contributor
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.