Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mappings #131

Merged
merged 5 commits into from
Mar 19, 2022
Merged

Add missing mappings #131

merged 5 commits into from
Mar 19, 2022

Conversation

ikari7789
Copy link

Not sure if this is the only thing that needs updated or not. Please let me know if anything additional is required. Thanks!

@ikari7789 ikari7789 changed the title Add mapping for Peter Grill to Kenja no Jikan Add missing mappings Feb 6, 2022
@BrutuZ
Copy link

BrutuZ commented Mar 15, 2022

tmdbid should only be set for Movies, not Series per ScudLee#342

@ikari7789
Copy link
Author

tmdbid should only be set for Movies, not Series per ScudLee#342

Sorry! I missed that in the README.md. I've removed them now. Thank you.

@BrutuZ
Copy link

BrutuZ commented Mar 19, 2022

It's understandable. HAMA does have a tsdb mode to account for different ID types, but AFAIK it doesn't pick automatically between series and movies according to the Plex Library type so it's s safer to strip these IDs to avoid what happened in the issue.

On a side-note, slightly surprised I overlooked Peter Grill 👀

@BrutuZ BrutuZ merged commit f17f446 into Anime-Lists:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants