-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Basic webmention support #39
base: master
Are you sure you want to change the base?
Conversation
Add configuration for endpoints.
This thing needs jQuery. Probably can be simplified to not include it.
This could probably get removed if I port comment section to vanilla JS. But for now let's go with that. It's cached anyway probably, everyone uses jQuery, right?
Thanks so much for submitting this PR! I've opened #40 for some additional tracking and will start reviewing your changes. |
I've added |
So this is taking a lot longer than I expected, as I learn about the intricacies of webmentions myself. One thing that I'm wondering is if it's worth downloading the whole jQuery library if we're only really interested in |
One thing that I'm wondering is if it's worth downloading the whole jQuery library if we're only really interested in `$.getJson()` — most modern browsers support ES6's [`fetch()`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch), which might be a little more lightweight (IE doesn't support it, so we might need a polypill there).
See [youmightnotneedjquery.com](http://youmightnotneedjquery.com/) for
some tips on how to replace jQuery and even remain compatible with some
reasonably recent versions of IE.
But seriously, I think alsmot nobody uses IE anymore.
Also CDN requests should be cached in browsers, if I understand it
properly, so I don't think jQuery requirement should be a problem for
most users. But don't count on my knowledge for this since I'm not sure.
|
About 88% of users can use |
Related Issue
Was discussed in email with repo owner. [Angelo: Issue #40 opened to track this]
Issue mentioned in post: https://fireburn.ru/post/why-my-site-looks-as-it-does/
Dependency Changes
Added jQuery. Can be removed if someone bothers to port comment section in single.html to vanilla JS.
Testing
Additional context
Like buttons are not included because: