Implement better openpmd metadata #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
OpenPMDDataReaderclass which is derived from the originalDataReaderof theopenpmd-viewer.The derived class has been extended with a method for reading only the field metadata.
This class replaces the functionality of
_read_field_metadatain theOpenPMDFieldReader, which had some problems in determining some metadata attributes (particularly the axis arrays) because it didn't have access to theFieldMetaInformation. The new class has access to it and is able to provide the more complete metadata generated by theopenpmd-viewer.