Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing HiPACE unit conversion definitions and some fixes #17

Merged
merged 18 commits into from
Jun 16, 2020
Merged

Implementing HiPACE unit conversion definitions and some fixes #17

merged 18 commits into from
Jun 16, 2020

Conversation

delaossa
Copy link
Contributor

@delaossa delaossa commented Jun 10, 2020 •
edited by AngelFP
Loading

Changes:

  • Implement HiPACE unit conversion.
  • Bug fixes in HiPACE implementation.
  • Add support for new Osiris data.
  • Define vector potential field A and add unit conversion.
  • Redefine normalized vector potential a as dimensionless.
  • Dimensionless fields won't be affected by unit conversion.

@AngelFP AngelFP self-assigned this Jun 16, 2020
@AngelFP
Copy link
Owner

AngelFP commented Jun 16, 2020

Well, I think this concludes it from my side, but let me know if you have any comments. And thanks again for the improvements!

@AngelFP AngelFP merged commit 75ba275 into AngelFP:general_redesign Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelFP AngelFP AngelFP approved these changes

Assignees

@AngelFP AngelFP

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delaossa @AngelFP