Conversation
Apply the upstream vLLM DSpark fix at build time without changing the pinned vLLM revision. Validate patch applicability against the exact lock in CI. Refs Anemll#11 Upstream: vllm-project/vllm#51538 Signed-off-by: code4me2 <velvetmoon222999@gmail.com>
Author
|
Live dual-GB10 validation is complete. Configuration
The runtime candidate was derived from Results
For transparency, an initial 660K calibration used a client timeout of 1,200 seconds and canceled before prefill completed. Both ranks remained synchronized and cancellation returned both GPUs cleanly to 0%. A cached follow-up completed in 52.925 seconds, after which the decisive test above was repeated from another fresh cold start with a 1,800-second timeout. The released DSpark-off service was restored after testing and passed real inference. Based on this result, I am marking the PR ready for review. |
Code4me2
marked this pull request as ready for review
August 26, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfecbb52ce1801d12e99c1d8bfb6e37a5530cd20from vLLM PR #51538Rationale
The vLLM revision pinned by this repository predates the upstream DSpark graph-replay safety fix. Its capture path still zero-initializes
sample_idx_mapping, which can make padded capture rows scatter into request slot 0. Its draft-input kernel can also route rejected or non-resident rows into physical KV block 0 rather thanPAD_SLOT_ID.Those defects are relevant to the intermittent first-request DSpark hang and TP-rank divergence reported in #11. Upstream #51538 specifically describes unsafe DSpark graph replay and draft-KV writes, and was subsequently validated by another contributor on a two-node GB10 TP=2 DSpark deployment.
This is intentionally not a backport of vLLM #48167. That change targets generic non-causal FlashInfer attention on SM100, while this repository uses its custom SM121 sparse-MLA path.
Scope
The patch is an unmodified, path-limited export of the upstream commit and applies cleanly to
VLLM_COMMIT=752a3a504485790a2e8491cacbb35c137339ad34. The vLLM, FlashInfer, and image version pins are unchanged.Validation
Static validation:
git diff --checkpy_compileLive validation used a runtime-equivalent image derived from
0.1.1with the exact PR-patched Python module installed on both ranks. The module SHA-256 matched across ranks.On two GB10 nodes with TP=2, DSpark k=5 probabilistic, native 1,048,576 context, concurrency 1, chunked prefill, prefix caching, and
FULL_AND_PIECEWISECUDA graphs:cold-660k-okThe released
0.1.1image with DSpark disabled was restored after testing and passed real inference.AI assistance
AI assistance was used for investigation, patch integration, and validation. The submitted runtime patch itself is the signed upstream vLLM change.
Refs #11