Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Ubuntu Dockerfile #107

Merged
merged 2 commits into from
Aug 19, 2023
Merged

An Ubuntu Dockerfile #107

merged 2 commits into from
Aug 19, 2023

Conversation

MolassesLover
Copy link
Contributor

Hi, there!

In hopes of running this project on Fedora Silverblue without having to figure out all the Fedora dependencies, I created a Dockerfile to build regardless of my system.

> **Note**: This commit message is written in Markdown for the sake of
clean documentation.

I'm not entirely sure if `deps_linux` is intended to *only* install
Ubuntu dependencies, as it checks for `apt`, and not the distribution
the script is being run on.

```
if [ -x "$(command -v apt)" ]; then
PKGMAN="apt"
```

Despite this, I'm assuming its intended for Ubuntu, as that seems to
be the primary GNU/Linux distribution used for the compilation of Aero.
Copy link
Owner

@Andy-Python-Programmer Andy-Python-Programmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! In the future tho, we might want to look into using cbuildrt for the overall build process. This would remove all of the host required dependencies (except for Qemu which is optional anyways).

LGTM!

@Andy-Python-Programmer Andy-Python-Programmer merged commit 08df5e4 into Andy-Python-Programmer:master Aug 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants