-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the Express request object as context #25
Conversation
…and other portions of the request object.
mhm such a functionality change would definitely need some documentation. What's the use case? Seems quite a niche from here |
Sorry about the lack of detail. I'm implementing a JSON API compliant API and there are some requirements in the specification that require members of the body to match the server's endpoint. This is one in particular that applies to updating resources:
This example from the spec shows the desired behavior with an endpoint like
Here
References can still reach the body of the request by referencing the body in the in the request object: |
…uest object. Update readme with docs showing this.
I appreciate this input.. I think it could end behind a flag. If I can get npm permissions I will be back with some more activity |
Sounds good. I'm happy to rework it as needed. |
Sorry guys very busy week, will leave this with @colthreepv, please go ahead with 0.5 merge, many thanks. |
Hi @amazzeo I brought your idea and commits in a new branch I put this functionality behind the flag Please review the branch and drop some feedback. |
Sorry for the delay in getting back to you! I think that works great, thanks for including it! |
Is this functionality going to be put into the master branch? The code seems to be stagnating in @colthreepv 's branch. |
Ouch.. quite some dust on this PR! |
merged and released 1.0.0 |
Allows access to params and other portions of the request object.