Skip to content

Conversation

@AndrewCsontos
Copy link
Owner

What
For TypeScript projects, developers would like to verify that their .ts and .tsx files compile in the lint-staged stop by running
tsc -noemit

Format, lint and test were running on .ts and .tsc files, but nothing was checking that TypeScript code compiled correctly.

How
Used ifTypeScript from utils to check if TypeScript is enabled.
If enabled, run tsc --noEmilt on all .ts and .tsx files

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Testing

  • Could not figure out the best way to test internally to the project, but tested in my own personal project.

@AndrewCsontos AndrewCsontos merged commit 15c3731 into master Apr 18, 2020
@AndrewCsontos AndrewCsontos deleted the tsc-lint-staged branch May 9, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants