Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendations #10

Merged
merged 7 commits into from
Jul 3, 2024
Merged

recommendations #10

merged 7 commits into from
Jul 3, 2024

Conversation

chu-andrew
Copy link
Contributor

Description

  • Implements a basic version of the recommendation system that I drafted here:
    Recommendation System Planning
    • justification for changes and chosen const value of VALUE_OF_SECOND is written in doc
  • Basic implementation of interest, preference, and transit scoring system
  • Further development of scoring systems and integration with application will be completed in future PRs.

Milestones

This PR works toward the following stories:

  • As a Matador user, I want to be able to search for specific terms (e.g. “parks”) and apply filters such as maximum transit cost and maximum transit time.
  • As a Matador user, I want to be able to specify whether my transit cost preferences are strong or soft, and whether my transit time preferences are strong or soft.
  • As a Matador user, I want to receive recommendations for places of interest in an order that optimizes my interest, money, and time.

Resources

@chu-andrew chu-andrew merged commit 1230eed into main Jul 3, 2024
}

function parseAccessibility(place) {
const TOTAL_ACCESSIBILITY_FIELDS = 4; // fields defined in Google Places API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could make a const list in the fetching utils which includes which fields are considered "accessibility". Then in this function use the length of that list. (That way if you add/remove some fields, you don't need to worry about updating the value in this file as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in d38f1b9

chu-andrew added a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants