Potential fix for code scanning alert no. 67: Use of dangerous function #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This autofix replaces the unsafe and obsolete 'gets()' function with a safer 'fgets()' implementation to prevent potential buffer overflow vulnerabilities. The fix allocates a buffer with a defined size and reads input securely from standard input using fgets(buf, sizeof(buf), stdin). Additionally, the obsolete declaration 'extern char *gets(FILE *stream);' was removed to ensure compliance with C11 and MISRA guidelines. No functional changes were introduced apart from enhancing security and standards compliance. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AndresMaqueo/codeql-coding-standards/security/code-scanning/67
To fix the problem, you should replace the use of
getson line 37 with a safer alternative. The recommended approach is to usefgets, which allows you to specify the maximum number of characters to read into the buffer, preventing buffer overflow. Since there is no buffer passed togetsin the provided code (reflecting a mistaken usage), the code should be updated to correctly allocate a buffer and callfgetsinstead. You need to declare a buffer with a fixed size, then usefgets(buffer, sizeof(buffer), stdin)to read from standard input. Update the function's implementation inf6and remove or comment out the incorrectextern char *gets(FILE *stream);declaration if necessary.No new imports are required since
<stdio.h>is already included.Suggested fixes powered by Copilot Autofix. Review carefully before merging.