Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_get_transaction_history() cover contract creation #142

Open
AndreMiras opened this issue Jul 29, 2018 · 0 comments
Open

test_get_transaction_history() cover contract creation #142

AndreMiras opened this issue Jul 29, 2018 · 0 comments
Labels
bug

Comments

@AndreMiras
Copy link
Owner

On contract creation the transaction dictionary has an empty a to field, but thecontractAddress is being filled up.
For example calling get_transaction_history() with address="0x02f8478cb5f78fdd702955a72e1895276765f482" will at some point fetch this tx https://etherscan.io/address/0x54c0de2318c89d598347b0000f26bad40c0ddf3b which is a contract creation.

This case needs to be unit tested. Also related to #141
AndreMiras added a commit that referenced this issue Jul 29, 2018
@AndreMiras
Handles contract creation tx, refs #142
6a6d91c 
Handles the scenario in the lib, but not in the test, refs #142
@AndreMiras AndreMiras added the bug label Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreMiras