Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valgrind workflow in CI #68

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix valgrind workflow in CI #68

merged 2 commits into from
Mar 17, 2022

Conversation

Anders429
Copy link
Owner

Fixes #65.

Seems valgrind being installed from source is more trouble than it's worth. Since I was installing from source to attempt to resolve an issue with running trybuild tests anyway, which we ended up skipping in the end, this reverts back to installing with apt-get.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #68 (a06a904) into master (80f7eca) will not change coverage.
The diff coverage is n/a.

❗ Current head a06a904 differs from pull request most recent head d6011bc. Consider uploading reports for the commit d6011bc to get more accurate results

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   21.68%   21.68%           
=======================================
  Files          55       55           
  Lines        4003     4003           
=======================================
  Hits          868      868           
  Misses       3135     3135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f7eca...d6011bc. Read the comment docs.

@Anders429 Anders429 merged commit 1fb7728 into master Mar 17, 2022
@Anders429 Anders429 deleted the valgrind branch March 17, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valgrind CI workflow is broken
2 participants