Big refacto - Step 1 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Mouradif
commented
Mar 29, 2022
Mouradif
commented
- Converted database module to a class
- Switched from taking callback params to returning promises
- Maps loaded to and served from from the database
- Made passwords case-sensitive again
- Converted database module to a class - Switched from taking callback params to returning promises - loading to and serving maps from the database - made passwords case-sensitive again
- Updating maps from editor - Initialize config for first install - Empty string password instead of undefined - Created table "maps_override" - WIP portal handling in maps route - Fixed some MMO_Core_NPCs event listeners (npc -> data)
|
@Mouradif Do we still merge this PR even tho we will replace the server with a submodule? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.