Skip to content

fix(i18n): localize Russian desktop tool titles - #3

Closed
DrMaks22 wants to merge 0 commit into
Anatoly17:feat/i18n-russian-localefrom
DrMaks22:codex/ru-desktop-tool-titles-polish
Closed

fix(i18n): localize Russian desktop tool titles#3
DrMaks22 wants to merge 0 commit into
Anatoly17:feat/i18n-russian-localefrom
DrMaks22:codex/ru-desktop-tool-titles-polish

Conversation

@DrMaks22

Copy link
Copy Markdown

Summary

  • add the missing Russian translations for Desktop assistant tool titles/actions
  • localize adjacent thread/clarify labels that were still falling back to English
  • keep provider/model/tool identifiers unchanged and preserve the existing defineLocale() structure

Validation

  • git diff --check
  • python3 /Users/lma/.codex/skills/ru-localization/scripts/lint_ru_quality.py /private/tmp/hermes-pr46634-audit --report /private/tmp/hermes-pr46634-audit-ru-quality.json
    • no findings in apps/desktop/src/i18n/ru.ts; remaining findings are pre-existing in unrelated locales/*.yaml / security docs
  • npm run typecheck --workspace apps/desktop
  • npm run test:ui --workspace apps/desktop -- src/i18n/languages.test.ts src/i18n/runtime.test.ts src/i18n/context.test.tsx src/components/language-switcher.test.tsx
    • 4 files / 22 tests passed

This is intended as a small follow-up to the already merged wording pass for the canonical RU Desktop branch.

@DrMaks22

Copy link
Copy Markdown
Author

Applied one final QA polish from an independent Russian wording pass: dynamic quoted tool titles now use a colon (Поиск: «query») instead of a looser concatenation.

Re-ran after the update:

  • git diff --check
  • npm run typecheck --workspace apps/desktop
  • npm run test:ui --workspace apps/desktop -- src/i18n/languages.test.ts src/i18n/runtime.test.ts src/i18n/context.test.tsx src/components/language-switcher.test.tsx -> 4 files / 22 tests passed
  • RU quality lint: still no findings in apps/desktop/src/i18n/ru.ts; remaining findings are pre-existing outside this PR

@Anatoly17
Anatoly17 force-pushed the feat/i18n-russian-locale branch from 501fdeb to e704708 Compare July 11, 2026 11:10
@Anatoly17

Copy link
Copy Markdown
Owner

Thanks, @DrMaks22 — both commits have now been integrated into feat/i18n-russian-locale via cherry-pick, with the original Git authorship preserved.

The updated branch passes:

  • Desktop typecheck
  • 4 i18n test files / 22 tests
  • git diff --check

The changes are now included in upstream PR NousResearch#46634. Closing this helper PR as integrated. Thank you for the focused QA and Russian wording polish.

@Anatoly17 Anatoly17 closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants