Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ui improvement in the FAQs #285

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

MurtazaShikari
Copy link
Contributor

Made some changes in the Help page UI

Fixes - #284

Made some ui changes in the title of the help page also added a hover effect which goes with the colour scheme of the website
Also works perfect for the small screens as well.

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for hungry-hero-ag ready!

Name Link
🔨 Latest commit 461f14a
🔍 Latest deploy log https://app.netlify.com/sites/hungry-hero-ag/deploys/653a9d195f4807000897eaf5
😎 Deploy Preview https://deploy-preview-285--hungry-hero-ag.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @MurtazaShikari 😃,

Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.

@Anandsg Anandsg self-requested a review October 26, 2023 07:00
Copy link
Owner

@Anandsg Anandsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine, but what i thought Right now, when users hover over the accordion header, only the text changes color. It's not always obvious to every user that it's a clickable feature. Some might instinctively try to click the entire header. My suggestion is to enhance the hover effect to cover the entire accordion header, making it more user-friendly.

When user hover anywhere in the accordion header change the text color to orange (as u did)

@MurtazaShikari
Copy link
Contributor Author

MurtazaShikari commented Oct 26, 2023

@Anandsg I have implemented the changes mentioned by you above
Now how should i create PR for the same? cuz i already have one PR open

@MurtazaShikari
Copy link
Contributor Author

@Anandsg have fixed the changes as mentioned above also had a suggestion i tried out this as well this also looks quite nice
image

@Anandsg Anandsg self-requested a review October 26, 2023 17:50
@Anandsg Anandsg merged commit ddbb455 into Anandsg:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants