feat(ics): add status X-MICROSOFT allDay support. closes #611 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldenquimby
commented
Sep 27, 2024
| @@ -13,6 +13,7 @@ interface CalendarEvent { | |||
| busy?: boolean; | |||
| guests?: string[]; | |||
| url?: string; | |||
| status?: 'CONFIRMED' | 'TENTATIVE' | 'CANCELLED'; | |||
There was a problem hiding this comment.
I prefer string literal unions over enums, but happy to switch this to an enum if that's what is preferred for this codebase
aldenquimby
commented
Sep 27, 2024
| @@ -70,6 +70,7 @@ for (const service of [ | |||
| title: "Birthday party", | |||
| start: "2019-12-29", | |||
| allDay: true, | |||
| status: "CONFIRMED", | |||
There was a problem hiding this comment.
Figured adding to a random test was sufficient, but I could add a new test just for this if you'd like. I would probably break out a new describe that is ics-specific, since status doesn't apply to the other services
|
@AnandChowdhary how does this look? |
|
@AnandChowdhary been a few months here - anything else I can do to help get this shipped? Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #611
Inspired by ical-generator