-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1.9.1 downloads #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the home url
, dev_url
, doc_url
, summary
and description
on the different about sections.
We might need to get the package to build on osx-64
and osx-arm64
just building s390x directly on builder ... CI build got stuck without any meaningful error-message :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…xnet-feedstock into update-1.9.1-downloads
Changes
Changes:
1.5.1
to1.9.1
.work around this by getting the archive commits from github.
Jira
https://anaconda.atlassian.net/browse/PKG-250
Review Information
Source
https://github.com/apache/incubator-mxnet/tree/1.9.1
License
Apache-2
https://github.com/apache/incubator-mxnet/blob/1.9.1/LICENSE
Upstream Changes
Releases from 1.5.1 to 1.9.1:
https://github.com/apache/incubator-mxnet/releases
Issues
https://github.com/apache/incubator-mxnet/issues
Pins and Requireds
https://github.com/apache/incubator-mxnet/blob/1.9.1/python/setup.py#L33
graphviz is removed (made optional) via patching.
Testing
No special testing has been performed.
Closing Comments
This needs a very careful review to ensure it's correct.