Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.9.1 downloads #11

Merged
merged 14 commits into from
Oct 24, 2022
Merged

Update 1.9.1 downloads #11

merged 14 commits into from
Oct 24, 2022

Conversation

ScottBailey
Copy link
Contributor

@ScottBailey ScottBailey commented Oct 13, 2022

Changes

Changes:

  • Update version from 1.5.1 to 1.9.1.
  • mxnet moved it's 3rdparty libs from source into git submodules. We
    work around this by getting the archive commits from github.
  • Ensure a modern compiler standard (c++14) is selected via patching.

Jira

https://anaconda.atlassian.net/browse/PKG-250

Review Information

Source

https://github.com/apache/incubator-mxnet/tree/1.9.1

License

Apache-2

https://github.com/apache/incubator-mxnet/blob/1.9.1/LICENSE

Upstream Changes

Releases from 1.5.1 to 1.9.1:

https://github.com/apache/incubator-mxnet/releases

Issues

https://github.com/apache/incubator-mxnet/issues

Pins and Requireds

https://github.com/apache/incubator-mxnet/blob/1.9.1/python/setup.py#L33
graphviz is removed (made optional) via patching.

Testing

No special testing has been performed.

Closing Comments

This needs a very careful review to ensure it's correct.

@varlackc varlackc self-requested a review October 18, 2022 22:14
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danpetry danpetry requested review from katietz and removed request for katietz October 19, 2022 10:51
@ScottBailey
Copy link
Contributor Author

1.5.1 still builds (see #14), so this is not a problem on the builder.

Here's a PR for testing hacks: #12

@katietz katietz self-assigned this Oct 21, 2022
@katietz katietz added the build label Oct 21, 2022
@katietz
Copy link
Contributor

katietz commented Oct 21, 2022

just building s390x directly on builder ... CI build got stuck without any meaningful error-message :/

@varlackc varlackc self-requested a review October 21, 2022 14:07
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katietz katietz merged commit ea58b05 into main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants