Update 0.28.1 #2
Conversation
Linter check found the following problems:Traceback (most recent call last): File "/opt/conda/envs/linter/bin/conda-lint", line 11, in sys.exit(main()) ^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/run.py", line 107, in main result = linter.lint( ^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 620, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 692, in lint_file messages = self.lint_recipe( ^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 748, in lint_recipe res = self.check_instances[check].run(recipe, fix) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 247, in run self.check_recipe(recipe) File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/check_build_help.py", line 555, in check_recipe o = int(path.split("/")[1]) ^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: 'host'ERROR conda.cli.main_run:execute(47): |
JeanChristopheMorinPerso
force-pushed
the
PKG-1647_update_0.28.1
branch
from
456641f
to
22233f6
Compare
Linter check found the following problems:Traceback (most recent call last): File "/opt/conda/envs/linter/bin/conda-lint", line 11, in sys.exit(main()) ^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/run.py", line 107, in main result = linter.lint( ^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 620, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 692, in lint_file messages = self.lint_recipe( ^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 748, in lint_recipe res = self.check_instances[check].run(recipe, fix) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 247, in run self.check_recipe(recipe) File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/check_build_help.py", line 555, in check_recipe o = int(path.split("/")[1]) ^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: 'host'ERROR conda.cli.main_run:execute(47): |
| @@ -134,7 +131,7 @@ outputs: | |||
| run: | |||
| - python | |||
| - {{ pin_subpackage('gymnasium', exact=True) }} | |||
| - mujoco-python >=2.2.0,<2.4 | |||
| - mujoco-python >=2.3.2,<2.4 | |||
There was a problem hiding this comment.
I think there is a difference between mujoco and mujoco-python:
https://github.com/Farama-Foundation/Gymnasium/blob/cab0fbb13d8f3c29c098939144fcbb183bede7f2/pyproject.toml#L44
https://github.com/Farama-Foundation/Gymnasium/blob/cab0fbb13d8f3c29c098939144fcbb183bede7f2/pyproject.toml#L46
mujoco-python has a lower constraint and is upper bound to 2.2.
There was a problem hiding this comment.
This one is confusing. There is a project called mujoco-py and there is a project called mujoco. There is also https://anaconda.org/conda-forge/mujoco-python and https://anaconda.org/conda-forge/mujoco which are both from deepmind.
On PyPI, mujoco corresponds to the DeepMind project and mujoco-py corresponds to the OpenAI project.
I don't think the situation could be more confusing than that...
So unless I'm mistaken, I think >=2.3.2,<2.4 is correct because in conda-forge, mujoco-python corresponds to https://pypi.org/project/mujoco/ in PyPI.
Or am I confused even more after writing all this? This is entirely possible.
There was a problem hiding this comment.
The gymnasium-mujoco subpackage definitely requires mujoco-python made by DeepMind and we have it https://github.com/AnacondaRecipes/mujoco-feedstock/blob/main/recipe/meta.yaml.
The gymnasium-mujoco_py subpackage definitely requires
mujoco-py which isn't maintained, see Farama-Foundation/Gymnasium#112 (comment). But yes, mujoco-py in pyproject.toml is mujoco-py made by OpenAI https://github.com/openai/mujoco-py#install-and-use-mujoco-py
| @@ -134,7 +131,7 @@ outputs: | |||
| run: | |||
| - python | |||
| - {{ pin_subpackage('gymnasium', exact=True) }} | |||
| - mujoco-python >=2.2.0,<2.4 | |||
| - mujoco-python >=2.3.2,<2.4 | |||
There was a problem hiding this comment.
The gymnasium-mujoco subpackage definitely requires mujoco-python made by DeepMind and we have it https://github.com/AnacondaRecipes/mujoco-feedstock/blob/main/recipe/meta.yaml.
The gymnasium-mujoco_py subpackage definitely requires
mujoco-py which isn't maintained, see Farama-Foundation/Gymnasium#112 (comment). But yes, mujoco-py in pyproject.toml is mujoco-py made by OpenAI https://github.com/openai/mujoco-py#install-and-use-mujoco-py
Linter check found the following problems:Traceback (most recent call last): File "/opt/conda/envs/linter/bin/conda-lint", line 11, in sys.exit(main()) ^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/run.py", line 107, in main result = linter.lint( ^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 620, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 692, in lint_file messages = self.lint_recipe( ^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 748, in lint_recipe res = self.check_instances[check].run(recipe, fix) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 247, in run self.check_recipe(recipe) File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/check_build_help.py", line 555, in check_recipe o = int(path.split("/")[1]) ^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: 'host'ERROR conda.cli.main_run:execute(47): |
JeanChristopheMorinPerso
requested review from
cbouss,
skupr-anaconda and
ryanskeith
Linter check found the following problems:Traceback (most recent call last): File "/opt/conda/envs/linter/bin/conda-lint", line 11, in sys.exit(main()) ^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/run.py", line 107, in main result = linter.lint( ^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 620, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 692, in lint_file messages = self.lint_recipe( ^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 748, in lint_recipe res = self.check_instances[check].run(recipe, fix) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/__init__.py", line 247, in run self.check_recipe(recipe) File "/opt/conda/envs/linter/lib/python3.11/site-packages/anaconda_linter/lint/check_build_help.py", line 555, in check_recipe o = int(path.split("/")[1]) ^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: 'host'ERROR conda.cli.main_run:execute(47): |
Update to 0.28.1.
Upstream diff: https://github.com/Farama-Foundation/Gymnasium/compare/v0.27.1..v0.28.1 (pyproject.toml)
conda-forge are still on 0.27.1, so no comparison for that.