Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe-variable-datetime 1.0.0 ❄️ #2

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

lorepirri
Copy link

@lorepirri lorepirri commented Jun 26, 2024

dedupe-variable-datetime 1.0.0 ❄️

Destination channel: Snowflake

Links

Explanation of changes:

  • new feedstock, fork from conda-forge
  • patch dependencies (wrong version of dedupe)
  • upstream tests
  • GH release archive for tests
  • add upload_channels

Depends on

Information for the reviewers

⚠️ There was no LICENSE file in the upstream. conda-forge adds a file with an MIT license, but nowhere is specified that it is so.

We requested one with dedupeio/dedupe-variable-datetime#8 and integrated here.

Before merging

  • contact authors of the package
  • decide which license file to use
  • update license

@skupr-anaconda
Copy link

The name of the license is mentioned here https://github.com/dedupeio/dedupe-variable-datetime/blob/fcd36afd000641168d9ae369623df866eeac35f9/pyproject.toml#L8 only.

As a warning:
Dedupe.io was shut down Jan 31, 2023.
see https://dedupe.io/

Is this library still relevant for usage?

@lorepirri
Copy link
Author

The name of the license is mentioned here https://github.com/dedupeio/dedupe-variable-datetime/blob/fcd36afd000641168d9ae369623df866eeac35f9/pyproject.toml#L8 only.

As a warning: Dedupe.io was shut down Jan 31, 2023. see https://dedupe.io/

Is this library still relevant for usage?

@skupr-anaconda this is an optional dependency of a direct SF request. It seems of common usage (as in fact it is wrongly included as runtime dependency) therefore we would like to ship this one.

@lorepirri lorepirri merged commit 27faa72 into main Jul 12, 2024
8 checks passed
@lorepirri lorepirri deleted the PKG-4963-dedupe-variable-datetime-1_0_0 branch July 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants