Update basemap to v1.3.1#4
Merged
Merged
Conversation
added 12 commits
February 10, 2022 12:46
- Update from `1.2.2` to `1.3.1`. - Consolidate `basemap-data-hires-feedstock` into this recipe. - Break existing `basemap` package into 2: the executable (`basemap`) and the standard resolution data (`basemap-data`). - Bring `basemap-data` and `basemap-data-hires` data contents to parity with upstream packaging. - This also removes the packaging workaround for data. - Data moves from our workaround location to site-data. - Patches simplified since data is now in the default location. - Fix patch. - Update pins.
| - python | ||
| - {{ pin_compatible('numpy') }} | ||
| - {{ pin_compatible('geos') }} | ||
| - matplotlib-base >=1.5,!=3.0.1 |
There was a problem hiding this comment.
matplotlib has a quite different pinning for v1.3.1 https://github.com/matplotlib/basemap/blob/9389196d81dc44809537e8196d8e7cb87e6bb1ef/packages/basemap/requirements.txt#L25. Can it be better to update to v1.3.2?
Author
There was a problem hiding this comment.
The pinning is different around numpy. I've pinned to the v1.3.2 requirements.
varlackc
reviewed
Feb 16, 2022
varlackc
left a comment
varlackc
left a comment
There was a problem hiding this comment.
we probably should use https instead of http for the home url and for the doc_url
varlackc
reviewed
Feb 16, 2022
varlackc
left a comment
varlackc
left a comment
There was a problem hiding this comment.
some versions of python older than 3.6 seem to be supported
Author
Fixed! |
skupr-anaconda
approved these changes
Feb 17, 2022
tobijk
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1.2.2to1.3.1.basemap-data-hires-feedstockinto this recipe.basemappackage into 2: the executable (basemap) and the standard resolution data (basemap-data).basemap-dataandbasemap-data-hiresdata contents to parity with upstream packaging.projfrom dependencies.NOTE:
linux-s390xarchitecture fails due to missing dependencies.Review Info
Changes
https://github.com/matplotlib/basemap/blob/v1.3.1/CHANGELOG.md
2 important items:
Issues
https://github.com/matplotlib/basemap/issues
There are plenty of issues, but I dont' see any obvious regressions that affect us.
v1.3.2
https://github.com/matplotlib/basemap/blob/v1.3.2/CHANGELOG.md
As I am preparing this PR, I noticed v1.3.2 was released. The biggest
issue is a CVE https://nvd.nist.gov/vuln/detail/CVE-2021-33430 that is
disputed. Secondary changes keep v1.3.2 from building without
significant additional work. Pinning
numpy >=1.21resolves the CVEissue. Unfortunately, numpy 1.21 is not available for
linux-ppc64le.Pins
https://github.com/pyproj4/pyproj/blob/48d922ad57316eab45d15ccfe41595c1e5e97039/setup.cfg#L38
pyproj dependency requires
py>=3.8https://github.com/matplotlib/basemap/blob/v1.3.2/packages/basemap/requirements.txt
numpy, matplotlib, pyproj, pyshp
Clossing Comments
The CVE is a MUCH bigger issue than this package and will need to be
handled repo wide if it is indeed valid.
Basic testing works.