Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

feat: d.js v14 #165

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

WilsontheWolf
Copy link
Contributor

@WilsontheWolf WilsontheWolf commented Jul 26, 2022

Everything should work, but I haven't tested too much.

BREAKING CHANGES:
Suprisingly not much.

  • Config file format changed to add support for new intents and partials
  • Bot no longer has the message content intent, which means it needs to be whitelisted and then enabled in the config.
    NOTE: the client still will receive message commands in dm's or when pinged.

Semantic versioning classification:

  • This PR changes the framework's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to README, etc.

Everything *should* work, but I haven't tested too much.

**BREAKING CHANGES:**
Suprisingly not much.

- Config file format changed to add support for new intents and partials
- Bot no longer has the message content intent, which means it needs to be whitelisted and then enabled in the config.
  NOTE: the client still will receive message commands in dm's or when pinged.
slash/leave.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link

@RealShadowNova RealShadowNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why is there a lockfile for NPM and Yarn?

@WilsontheWolf
Copy link
Contributor Author

Idk but it was like that when I got to it

Copy link

@GoldenAngel2 GoldenAngel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these, it looks good.

commands/stats.js Outdated Show resolved Hide resolved
slash/stats.js Outdated Show resolved Hide resolved
Copy link

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultPermission can be updated to use dmPermission

config.js.example Outdated Show resolved Hide resolved
Copy link

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that was introduced with 14.1.0:

events/interactionCreate.js Outdated Show resolved Hide resolved
@WhyAydan
Copy link

Hey,

Any update when this will be pushed live?

Aydan

- Update deps
- Update readme
- Revert isCommand
@WilsontheWolf WilsontheWolf requested review from kyranet and RealShadowNova and removed request for kyranet November 12, 2022 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants