This repository was archived by the owner on May 27, 2025. It is now read-only.
Conversation
Signed-off-by: Tim van Oostrom <tim@depulz.nl>
jonkoops
approved these changes
Jan 25, 2021
Contributor
jonkoops
left a comment
jonkoops
left a comment
There was a problem hiding this comment.
LGTM @timvanoostrom, this also works with the Storybook?
Contributor
Author
|
Yes works. |
Contributor
Author
|
@jonkoops how can one update the netlify node engine? Building fails because:
|
Contributor
|
I'll fix the problems with Netlify in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bg images would not show up in our app. Apparently this might be caused by a file-loader module default in create-react-app dependency. facebook/create-react-app#9934
Chaning the import style works for both stories as well as our app.
I couldn't get TS to be satisfied though that's why I added the @ts-ignore directive. I've tried adding a module declaration in types.d.ts as described here microsoft/TypeScript-React-Starter#12 but I could not get that to work. Any help/ideas are appreciated.
Signed-off-by: Tim van Oostrom tim@depulz.nl