-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lodash to v4 #241
Bump lodash to v4 #241
Conversation
@wraithgar @latentflip @cdaringe @pgilad I've taken a first swing at updating AmpersandJS to lodash v4. A few of the packages depend on other ampersand packages that need to be updated, which I've noted below. #241 Depends on Depends on If there's anything I can do to help merge these quickly, let me know. They should all be fairly straightforward. |
Verified that all zuul tests run via #242 |
@pgilad thanks for looking through these. is there another person on the ampersand team who can give a second thumbs up? |
ping @AmpersandJS/core-team |
+1 |
1 similar comment
+1 |
@cdaringe @lukekarrys thanks. could one of you look through the related commits above? these changes are much more impactful if they are done across the ampersand project -- it makes it possible to transition entirely to lodash v4 instead of requiring two different versions. This can be a huge difference in number of bytes. |
@cdaringe @lukekarrys @pgilad i'm getting the sinking feeling this project isn't being actively maintained. is there a clear person i should work with to get these merged and pushed to NPM? is the best option forking all the libraries? |
hey @samhashemi, sorry to give that impression :/ my experience has told me that we've had the implicit practice of letting the package maintainer take charge of merge/publish. im not sure who does -state, but i'm sure it was just a case of "too-busy." thanks for following up. we'll get it taken care of. |
@pgilad let me know if you want me to publish |
@cdaringe thanks! is there a list of who the maintainer is for each ampersand project? i'd like to get the 10 PRs above merged in parallel. |
@cdaringe I think at one point I was, but I'm taking a back seat from things right now, so if you have publish bits go ahead and do what you think's right :) |
@samhashemi, it should be listed on the packages (like here) i'll publish this bad boy :) |
|
Okay, I definitely shouldn't be listed as I'll be of no use, so I opened this: #243 |
Publish, and publish all related repositories as well... I didn't have publish rights to all of them so decided not to get stuck in the middle of the upgrade. I do admit I use ampersand less these days (react + redux mainly) but am happy to contribute when I have time |
No description provided.