Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch User Blogs(Fixed) #25

Merged
merged 8 commits into from
May 13, 2018
Merged

Fetch User Blogs(Fixed) #25

merged 8 commits into from
May 13, 2018

Conversation

akatsukilevi
Copy link
Contributor

  • Function getUserBlogs (Fetch blogs from specified User on specified Community) (Fixed to not mess the old changes)

@akatsukilevi akatsukilevi requested review from moelrobi and felixfong227 and removed request for moelrobi April 21, 2018 19:08
@moelrobi moelrobi added the enhancement New feature or request label Apr 21, 2018
@moelrobi moelrobi added this to the The Blog Update (0.2) milestone Apr 21, 2018
felixfong227
felixfong227 reviewed Apr 22, 2018
View reviewed changes
Copy link
Member

@felixfong227 felixfong227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code looks awesome, but you might want to consider using isomorphic-fetch instead of request-promise 👉

@moelrobi moelrobi added the MajorUpdate All PR's / Issues that are with the latest major Update. label Apr 22, 2018
moelrobi
moelrobi approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@moelrobi moelrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the Libary, switched to the other Module.

@moelrobi moelrobi merged commit 6c0ef2b into AminoJS:blogdev May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfong227 felixfong227 felixfong227 left review comments

@moelrobi moelrobi moelrobi approved these changes

Assignees

@akatsukilevi akatsukilevi

Labels
enhancement New feature or request MajorUpdate All PR's / Issues that are with the latest major Update.
Projects
None yet
Milestone
The Blog Update (0.2)
Development

Successfully merging this pull request may close these issues.
3 participants
@akatsukilevi @felixfong227 @moelrobi