Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@deadarm
Copy link
Contributor

@deadarm deadarm commented Feb 8, 2017

Prevents jquery conflicts and addresses errors.

Steps to test

  1. Navigate to ~/www/AMA-style-guide/styleguide
  2. Run composer install
  3. Run gulp serve
  4. Navigate to home page template
  5. Use small viewport
  6. Click on Audience Selector and verify it opens and closes
  7. Verify there are no errors in console
  8. Click on Atoms > View all
  9. Verify that you can see all atoms

@deadarm deadarm requested a review from froboy February 8, 2017 18:20
@froboy
Copy link
Contributor

froboy commented Feb 14, 2017

This fixes some things, but looks like if you click Atoms > All the error still comes up. Looks like it starts in init.js, maybe? @deadarm could you check this out?

@deadarm deadarm force-pushed the styleguide-js-error branch 2 times, most recently from 603ba83 to d1522e3 Compare February 20, 2017 20:07
@deadarm deadarm force-pushed the styleguide-js-error branch from d1522e3 to 8c56f15 Compare February 20, 2017 21:58
@froboy
Copy link
Contributor

froboy commented Feb 24, 2017

Fix as per pattern-lab/patternlab-php-core#102

Copy link
Contributor

@martensc martensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify that the Audience Selector opened and closed.

I was able to view all Atoms.

I did receive this error though in my console display in both instances:
screen shot 2017-02-24 at 3 02 11 pm

@froboy
Copy link
Contributor

froboy commented Feb 24, 2017

@martensc can you be sure you ran composer install and then check to see if you have this commit in your Builder.php pattern-lab/patternlab-php-core@c976fa4

@martensc
Copy link
Contributor

@froboy I ran composer install initially. Not sure if something went wrong with it though.

I'm not seeing Builder.php

@froboy
Copy link
Contributor

froboy commented Feb 24, 2017

@martensc check at styleguide/vendor/pattern-lab/core/src/PatternLab/Builder.php?

@martensc
Copy link
Contributor

@froboy it looks like Builder.php is setup correctly. Here is my terminal window when I run composer install.
screen shot 2017-02-27 at 11 07 45 am

I see the same console error: Uncaught TypeError: $ is not a function when viewing all Atoms.

@froboy
Copy link
Contributor

froboy commented Feb 27, 2017

@martensc can you try one more time? This works for realsies now.

@martensc
Copy link
Contributor

@froboy it's working great now! No errors.

@froboy froboy merged commit 7ef1f14 into develop Feb 28, 2017
@froboy
Copy link
Contributor

froboy commented Feb 28, 2017

@martensc thanks!!!!!!!

@froboy froboy deleted the styleguide-js-error branch February 28, 2017 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants