-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage #183
Add test coverage #183
Conversation
Hi @bgrnwd , the pipeline fails at the "Pytest coverage comment" step when it tries to comment on this PR.
But it is successful on my fork - https://github.com/rbarman/itscalledsoccer/actions/runs/9917117549/job/27400194105 I'm skimming through some other threads like actions/labeler#12 and it looks like the issue is that PRs from forks have read only access to the main repo and thus it can't create the coverage comment. Might have to do more research, but some possible options that come to mind:
|
@rbarman Just saw your comment. I think the first option is the way to go for now and we can add a Code Cov badge to the README. |
Alright, I need to create another commit to go with option 1 |
@bgrnwd , thanks for merging. Just as a reminder, you or the repo owners will need to enable this repo with Codecov and set the CODECOV_TOKEN as a repository secret. You go to repo settings -> "Secrets and variables" -> "Actions" -> "New Repository Secret" Because I just checked the github action runs for this PR (https://github.com/American-Soccer-Analysis/itscalledsoccer/actions/runs/9967409315/job/27541042634#step:7:34) and see:
|
Looks like we already have a |
Description
Add test coverage (#181)
The
.github/workflows/python-tests.yml
workflow now:Also updated
CONTRIBUTING.md
with steps on how to locally generate the test coverage report.Checklist
Additional Comments
Repo owners will need to enable this repo with Codecov and set the
CODECOV_TOKEN
as a repository secret.