Campfire serve and open-browser #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ten3roberts
force-pushed
the
web-workflow
branch
from
5ab9cc7
to
2a5fb5c
Compare
ten3roberts
force-pushed
the
web-workflow
branch
from
36ec294
to
5ed3497
Compare
ten3roberts
force-pushed
the
web-workflow
branch
2 times, most recently
from
155b51d
to
2c59248
Compare
ten3roberts
force-pushed
the
web-workflow
branch
from
2c59248
to
be1cefa
Compare
philpax
reviewed
Aug 9, 2023
| @@ -323,7 +323,7 @@ fn material_filter_matches(filter: &MaterialFilter, mat: &PbrMaterialDesc) -> bo | |||
| // } | |||
| // } | |||
|
|
|||
| pub const MODEL_EXTENSIONS: &[&str] = &["glb", "fbx", "obj", "x"]; | |||
| pub const MODEL_EXTENSIONS: &[&str] = &["glb", "gltf", "fbx", "obj", "x"]; | |||
There was a problem hiding this comment.
lol nice, I guess this fixes #644 as well
There was a problem hiding this comment.
Yes, did it while pairing with @chaosprint and it just came up and we did it on the go while discussing how my edit-build-test workflow loop looks 😆
philpax
approved these changes
Aug 9, 2023
philpax
reviewed
Aug 9, 2023
| // return false; | ||
| // } | ||
|
|
||
| match fname.to_str() { |
There was a problem hiding this comment.
looking at this - maybe, as a future extension, it should respect .gitignore? definitely not necessary now, just figured I'd plant the idea
There was a problem hiding this comment.
Yes, figured as such as well.
Oh .DS_STORE how I've missed you
|
Accidentally fixes #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the web workflow through campfire