Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for watchOS. #367

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add support for watchOS. #367

merged 1 commit into from
Jan 11, 2023

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Jan 4, 2023

This PR adds support to parking_lot for watchOS. This can be tested by building on a mac with the following command when the watchOS SDK is installed through Xcode:

cargo build -Zbuild-std --target=arm64_32-apple-watchos

The support simply mirrors macOS and iOS support.

Note: I've also got a watchos-0.8 branch with the changes cherry picked onto backport-core-0.8, I'm not exactly sure how backports are handled.

Mirrors macOS and iOS.
@Amanieu
Copy link
Owner

Amanieu commented Jan 7, 2023

Would it make sense to add tvos as well?

Regarding backports, I prefer not to unless there is a very good reason. Generally speaking the only supported version of this crate is the latest published version. If you need support for watchOS then you should upgrade your dependencies to the latest version.

@pixlwave
Copy link
Contributor Author

Hey, sorry for the slow reply. It would be nice to add tvos too, but it doesn't have support for std yet (although that seems to be in progress). From what I can tell parking_lot doesn't work for no_std targets, although I'm still fairly new to Rust so could easily be missing something here.

Understood on the backports, makes total sense to me :)

@Amanieu Amanieu merged commit afacc0f into Amanieu:master Jan 11, 2023
@pixlwave
Copy link
Contributor Author

Wooo, thanks 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants