Replace Instant with dummy on wasm32-unknown-unknown #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 1 commit into Amanieu:master from d3lm:master

Apr 21, 2020

+46 −6

Contributor

d3lm commented Apr 21, 2020

No description provided.

d3lm mentioned this pull request

wasm implementation of RawMutex and RawRwlock using UnsafeCell #187

Closed

Contributor Author

d3lm commented Apr 21, 2020 •

edited

Loading

Ah wait! I suppose that now() should at least return a number, right? As in 0 maybe.

Or should it return self? I mean Instant::now() returns an Instant by doing Instant(now) internally.

Contributor Author

d3lm commented Apr 21, 2020

Fixing it.

Amanieu reviewed

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

d3lm force-pushed the master branch from d5e8359 to e96c209 Compare

April 21, 2020 14:31

Contributor Author

d3lm commented Apr 21, 2020

Alright. The PR is updated and it successfully builds.

Amanieu reviewed

View reviewed changes

core/src/parking_lot.rs Show resolved Hide resolved

Amanieu reviewed

View reviewed changes

core/src/parking_lot.rs Outdated Show resolved Hide resolved

d3lm changed the title ~~Replace Instant with dummy on wasm32~~ Replace Instant with dummy on wasm32-unknown-unknown

Contributor Author

d3lm commented Apr 21, 2020 •

edited

Loading

Yay, Travis goes green ✅ I ll push the changes you mentioned.

d3lm force-pushed the master branch from e96c209 to 0f890b3 Compare

April 21, 2020 14:50

Contributor Author

d3lm commented Apr 21, 2020

Updated 👍

Amanieu reviewed

View reviewed changes

core/src/parking_lot.rs Outdated Show resolved Hide resolved

Amanieu reviewed

View reviewed changes

core/src/parking_lot.rs Outdated Show resolved Hide resolved


          Replace Instant with dummy on wasm32-unknown-unknown

06b2037

d3lm force-pushed the master branch from 0f890b3 to 06b2037 Compare

April 21, 2020 14:57

Owner

Amanieu commented Apr 21, 2020

bors r+

Owner

Amanieu commented Apr 21, 2020

Thanks!

Contributor Author

d3lm commented Apr 21, 2020 •

edited

Loading

Thank YOU 🙏 for being so active and responsive and also for providing this library. Really great work.

Contributor

bors bot commented Apr 21, 2020

Build succeeded:

continuous-integration/travis-ci/push

bors bot merged commit 70a851c into Amanieu:master

Contributor Author

d3lm commented Apr 21, 2020

@Amanieu Will you release this today as well? Would be really cool.

d3lm mentioned this pull request

Use of Instant::now() does not work on wasm32-unknown-unknown #166

Closed

dependabot bot mentioned this pull request

Update parking_lot requirement from 0.10 to 0.11 wingertge/artemis#14

Merged

JanKaul mentioned this pull request

Use of parking_lot 0.7.1 does not work on wasm32-unknown-unknown swc-project/swc#2555

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet