Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2628): generate eol LF config #2635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#2628): generate eol LF config #2635

wants to merge 1 commit into from

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

Generate eol LF config

Related issues

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner December 19, 2024 13:30
@matthieu-crouzet matthieu-crouzet force-pushed the fix/2628 branch 2 times, most recently from 7b41e4e to c22bda8 Compare December 20, 2024 06:41
Copy link

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit 1572429.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 54m 56s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 53s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx affected --target=test --cacheDirectory=/hom... ✅ Succeeded 11s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx affected --base=remotes/origin/main --target... ✅ Succeeded 2s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 12:00:44 UTC

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.77%. Comparing base (a2ea47b) to head (1572429).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const updateEditorConfig: Rule = (tree) => {
const editorconfigPath = '.editorconfig';
const editorconfig = tree.exists(editorconfigPath) ? tree.readText(editorconfigPath) : '';
const newEditorconfig = /\[[*]\]/.test(editorconfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should not append end_of_line if already defined in the file

if (editorConfig.includes('end_of_line')) {
  return tree;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: @o3r/create should generate end-of-line LF config
4 participants