-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2628): generate eol LF config #2635
base: main
Are you sure you want to change the base?
Conversation
7b41e4e
to
c22bda8
Compare
View your CI Pipeline Execution ↗ for commit 1572429.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
c22bda8
to
419f669
Compare
419f669
to
1572429
Compare
const updateEditorConfig: Rule = (tree) => { | ||
const editorconfigPath = '.editorconfig'; | ||
const editorconfig = tree.exists(editorconfigPath) ? tree.readText(editorconfigPath) : ''; | ||
const newEditorconfig = /\[[*]\]/.test(editorconfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should not append end_of_line
if already defined in the file
if (editorConfig.includes('end_of_line')) {
return tree;
}
Proposed change
Generate eol LF config
Related issues