-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devexp): highlight components by group #2540
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 29dfdcc.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
f923307
to
01e1747
Compare
01e1747
to
5e2bf4a
Compare
5e2bf4a
to
23305f5
Compare
23305f5
to
29dfdcc
Compare
* Stop the highlight of elements | ||
*/ | ||
public stop() { | ||
this.cleanHighlightWrapper(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of cleaning the wrapper element you can only remove the wrapper from the DOM so that it won't stay even if you stop the highlight.
}, []); | ||
|
||
const overlayData: Record<string, { chip: HTMLElement; overlay: HTMLElement; depth: number }[]> = {}; | ||
elementsWithInfoAndDepth.forEach((item) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add a logic to change the line style and play with the shadows based on odd/even depths to help to distinguish layers
Here we don't understand that ngb3 and ngb4 are included into ngb2
Also to help to understand that ngb4 overlap ngb3 you can differentiate the chip font (like using italic style for overlapping element) to help to understand that ngb3 and ngb4 are both one on the other
*/ | ||
export function runRefreshIfNeeded(mutations: MutationRecord[], highlightWrapper: Element | null, refreshFn: () => void) { | ||
if ( | ||
mutations.some((mutation) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related issues
🚀 Feature #2532
How to test
yarn && yarn nx serve showcase
With
postMessage
(chrome extension part is not done yet)elementMinWidth
,elementMinHeight
,throttleInterval
andmaxDepth
)