fix(training): missing files for training-sdk tests #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 90f4825. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
bug
kpanot
reviewed
Nov 13, 2024
kpanot
reviewed
Nov 13, 2024
| displayName: require('../package.json').name, | ||
| moduleNameMapper: { | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| '^@o3r-training/training-sdk$': ['<rootDir>/dist/cjs', '<rootDir>/src'], |
There was a problem hiding this comment.
Why the cjs is mandatory here? (Without it you would not be this manual mapping :S)
There was a problem hiding this comment.
no idea, I copy pasted from showcase-sdk
I can remove it for both
fpaul-1A
force-pushed
the
fix/otter-training-sdk-test
branch
from
55eda3a to
90f4825
Compare
kpanot
approved these changes
Nov 14, 2024
sdo-1A
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues
- No issue associated -