feat: otter training - training sdk #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieu-crouzet
approved these changes
Oct 10, 2024
sdo-1A
force-pushed
the
feat/training-sdk
branch
from
af59293 to
1f975b9
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f78569f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
cpaulve-1A
reviewed
Oct 10, 2024
cpaulve-1A
reviewed
Oct 10, 2024
cpaulve-1A
reviewed
Oct 10, 2024
sdo-1A
force-pushed
the
feat/training-sdk
branch
from
1f975b9 to
e359fd8
Compare
cpaulve-1A
reviewed
Oct 10, 2024
fpaul-1A
reviewed
Oct 10, 2024
fpaul-1A
reviewed
Oct 10, 2024
kpanot
reviewed
Oct 10, 2024
sdo-1A
force-pushed
the
feat/training-sdk
branch
from
e359fd8 to
2864524
Compare
kpanot
reviewed
Oct 15, 2024
| "options": { | ||
| "script": "extract" | ||
| }, | ||
| "inputs": ["source", "^source-and-cli", "{projectRoot}/package.json"], |
There was a problem hiding this comment.
Why do you need ^source-and-cli?
This will require to re-run this action on any dependency source code change.
It is what you want or is ^cli would be enough (according where o3r-extract-folder-structure is)?
sdo-1A
force-pushed
the
feat/training-sdk
branch
from
2864524 to
41541fd
Compare
fpaul-1A
approved these changes
Oct 16, 2024
cpaulve-1A
reviewed
Oct 16, 2024
| "options": { | ||
| "script": "build" | ||
| }, | ||
| "inputs": ["source", "^source-and-cli"] |
There was a problem hiding this comment.
We should not need this line
cpaulve-1A
reviewed
Oct 17, 2024
sdo-1A
force-pushed
the
feat/training-sdk
branch
from
41541fd to
f78569f
Compare
cpaulve-1A
approved these changes
Oct 18, 2024
kpanot
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Creation of training SDK
This PR is mainly to check the package files, the specifications are likely to change when we update the content of the SDK training exercises.
Related issues