Fixed issue when scan job could restart every time when we have activity navigation #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidgyoung Please take a look Thanks a lot! |
|
I am thinking about using ProcessLifecycleOwner.get().getLifecycle() as it's more accurate than activities.. |
VolodaUa
force-pushed
the
bugfix/repeadly-scan-job-restart-on-navigation
branch
from
2a1c98b to
072437e
Compare
…er activity opened, but old one was stopped - use ProcessLifecycleOwner callbacks to detect if the app is foreground or background
VolodaUa
force-pushed
the
bugfix/repeadly-scan-job-restart-on-navigation
branch
from
072437e to
e0975f1
Compare
|
Hi @davidgyoung Could you please prepare a beta version with this fix? I locally tested it a lot and it works. |
|
Hi @davidgyoung We tested this solution with QA for a while. The application faced this issue once we started using this library. The fix solved the problem and then the app worked well. No more complains. I had to use reflection to replace the affected class in the library with my own. It's not good, but it the solution for now. Please let me know if I need to provide more information. |
|
Thank you @VolodaUa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix fixes the issue when we have the scan job restarting every time during navigation (activity opening) in the app.
Background mode - is set only if the user puts the app in the background or it keeps the background when startMonitoring was called in Application.onCreate during app start(as designed for background scanning).
Foreground mode - is set only one time when app become foreground. Fixed also an issue when starting activity is like the facade to find the proper starting activity to proceed app starting.
Fixes: #1194