[d3d8] Release refs on previous render targets and depth stencils #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and these refcount leveling releases apparently regress Borderzone, which now crashes on startup. I'm beginning to think I'm either missing something or there's simply no way to please every game at once. Still, as far as the current state of main is concerned, this PR should fix more than it breaks. |
|
We'll sort this out another way, turns out it's not such a great idea to ref() after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you are aware, the added .ref()s in 08e183f regress almost every game that had issues with refcounts and was fixed by #122, namely the 2 BloodRaynes, Blowout and Firestarter.
The D3D8 docs say the following with regards to IDirect3DDevice8::SetRenderTarget:
The device will call AddRef on each non-NULL surface passed to SetRenderTarget. After that the device calls Release on the previously set color buffer.Doing exactly that fixes all the above problematic games again, so seems to be a good avenue to explore. I am hoping it will also address the regression with MGS2 in way that doesn't crash the game again, but I don't have the game so can't confirm.