⬆️ Upstream sync — v0.42.3

.claude/agents/rust-rtk.md

@@ -397,7 +397,7 @@ docker run --rm -v $(pwd):/rtk -w /rtk rust:latest cargo test  # Linux via Docke
 ✅ **DO** compile regex once with `lazy_static!`
 ✅ **DO** verify token savings claims in tests (≥60%)
 ✅ **DO** test on macOS + Linux + Windows (via CI or manual)
-✅ **DO** run `cargo fmt && cargo clippy && cargo test` before commit
+✅ **DO** run `cargo fmt && cargo clippy --all-targets && cargo test` before commit
 ✅ **DO** benchmark startup time with `hyperfine` (<10ms target)
 ✅ **DO** use `anyhow::Result` with `.context()` for all error propagation
 

.claude/commands/tech/codereview.md

@@ -230,12 +230,12 @@ Glob tests/fixtures/<cmd>_raw.txt
            └────────┬────────┘
                     │
                     ▼
-           ┌──────────────────────┐
-           │  3. Quality gate     │
-           │  cargo fmt --all     │
-           │  cargo clippy        │
-           │  cargo test          │
-           └────────┬─────────────┘
+     ┌─────────────────────────────┐
+     │  3. Quality gate            │
+     │  cargo fmt --all            │
+     │  cargo clippy --all-targets │
+     │  cargo test                 │
+     └──────────────┬──────────────┘
                     │
               Loop ←┘ (max N iterations)
 ```

.github/scripts/ai_security_review.py

@@ -0,0 +1,167 @@
+import subprocess, json, os, re, urllib.request
+
+BASE = os.environ.get('BASE_REF', 'origin/main')
+HEAD = os.environ['HEAD_REF']  # e.g. "v0.42.3" — required
+
+# --- commits section (capped) ---
+commits_raw = subprocess.check_output(
+    ['git', 'log', f'{BASE}..{HEAD}', '--oneline'], text=True
+).strip()
+commit_lines = commits_raw.splitlines()
+if len(commit_lines) > 100:
+    commits = '\n'.join(commit_lines[:100]) + f'\n[... {len(commit_lines) - 100} more commits]'
+else:
+    commits = commits_raw
+
+# --- diff section (Rust-relevant paths, capped; Cargo.lock excluded — cargo audit covers it) ---
+diff = subprocess.check_output(
+    ['git', 'diff', f'{BASE}..{HEAD}', '--',
+     'src/', 'build.rs', 'Cargo.toml', 'install.sh', '.claude/'],
+    text=True
+)
+diff_lines = diff.splitlines()
+truncated = len(diff_lines) > 1500
+if truncated:
+    diff = '\n'.join(diff_lines[:1500]) + '\n\n[TRUNCATED — see full diff in GitHub PR]'
+
+# --- trust-critical modules: always include full contents at HEAD ---
+TRUST_CRITICAL = ['src/core/telemetry.rs', 'src/discover/registry.rs']
+critical_parts = []
+for path in TRUST_CRITICAL:
+    try:
+        content = subprocess.check_output(['git', 'show', f'{HEAD}:{path}'], text=True)
+        critical_parts.append("### " + path + "\n```rust\n" + content + "\n```")
+    except subprocess.CalledProcessError:
+        critical_parts.append("### " + path + "\n[Not present at " + HEAD + " — may have moved; flag this]")
+critical_section = (
+    "\n\n## Trust-Critical Module Full Contents\n"
+    "These modules are reviewed in full every sync regardless of diff size. "
+    "telemetry.rs is the only network-calling module; registry.rs decides how "
+    "Bash commands are rewritten and auto-approved.\n\n"
+    + "\n\n".join(critical_parts)
+)
+
+# --- automated pattern scan over changed .rs files + trust-critical modules ---
+DANGER_PATTERNS = [
+    (r'Command::new|\.spawn\(|\.output\(\)', 'exec: process execution'),
+    (r'https?://', 'network: hardcoded URL'),
+    (r'ureq::|reqwest|TcpStream|UdpSocket', 'network: client usage'),
+    (r'env::var\([^)]*(KEY|TOKEN|SECRET|PASSWORD|CREDENTIAL)', 'creds: secret env read'),
+    (r'\.ssh|\.aws|\.netrc|\.gnupg', 'creds: credential path'),
+    (r'\.claude', 'fs: ~/.claude access'),
+    (r'\bunsafe\b', 'mem: unsafe block'),
+    (r'base64', 'obfuscation: base64'),
+    (r'include_(bytes|str)!', 'embed: compile-time file embed'),
+]
+
+changed = subprocess.check_output(
+    ['git', 'diff', '--name-only', f'{BASE}..{HEAD}', '--', 'src/', 'build.rs'],
+    text=True
+).splitlines()
+scan_files = sorted(set(
+    [p for p in changed if p.endswith('.rs')] + TRUST_CRITICAL
+))
+
+scan_findings = []
+for path in scan_files:
+    try:
+        lines = subprocess.check_output(['git', 'show', f'{HEAD}:{path}'], text=True).splitlines()
+    except subprocess.CalledProcessError:
+        continue  # deleted or moved at HEAD
+    for i, line in enumerate(lines, 1):
+        stripped = line.strip()
+        if stripped.startswith('//'):
+            continue
+        for regex, label in DANGER_PATTERNS:
+            if re.search(regex, line):
+                scan_findings.append("  [{}] {}:{} — {}".format(label, path, i, stripped[:160]))
+
+scan_section = "\n\n## Automated Pattern Scan\n"
+scan_section += "Scanned {} changed/trust-critical .rs files at {}.\n".format(len(scan_files), HEAD)
+if scan_findings:
+    if len(scan_findings) > 200:
+        scan_findings = scan_findings[:200] + ["  [... truncated at 200 hits]"]
+    scan_section += "Matched {} pattern(s):\n".format(len(scan_findings))
+    scan_section += "\n".join(scan_findings)
+else:
+    scan_section += "No danger patterns matched."
+
+# --- build prompt ---
+prompt = (
+    "You are a security reviewer for a personal fork of rtk-ai/rtk (RTK, 'Rust Token Killer').\n\n"
+    "RTK is a Rust CLI that a Claude Code PreToolUse hook routes EVERY Bash command through: "
+    "`rtk rewrite` can rewrite commands and auto-approve them. A malicious change could therefore "
+    "execute or exfiltrate anything. I review every upstream release before building the binary "
+    "I run locally. Trust-critical paths: src/core/telemetry.rs (only legitimate network caller — "
+    "opt-in daily HTTPS ping) and src/discover/registry.rs (command rewrite rules).\n\n"
+    "Upstream release range under review: " + BASE + " -> " + HEAD + "\n\n"
+    "New commits:\n" + commits + "\n\n"
+    "Diff (Rust-relevant files only" + (", truncated" if truncated else "") + "):\n"
+    + diff
+    + critical_section
+    + scan_section
+    + "\n\n"
+    "Your job:\n"
+    "1. Summarize what changed in 2-4 plain English sentences.\n"
+    "2. Flag any of the following if present (with file:line reference):\n"
+    "   - New network calls or hardcoded URLs outside telemetry.rs, or telemetry changes "
+    "(new endpoints, new data fields, consent-check removal)\n"
+    "   - New process execution (Command::new / spawn) or changes to how rewritten commands are constructed\n"
+    "   - Rewrite-registry changes that could auto-approve dangerous commands or inject arguments\n"
+    "   - New filesystem access to credential paths (~/.ssh, ~/.aws, ~/.netrc) or ~/.claude\n"
+    "   - New environment variable reads of secrets\n"
+    "   - New dependencies or build.rs changes in Cargo.toml/build.rs\n"
+    "   - New unsafe blocks, base64/obfuscation, or compile-time embedded blobs\n"
+    "   - Changes under .claude/ (skills/commands that auto-load into Claude Code sessions) — treat as a prompt-injection surface\n"
+    "   - Automated pattern scan hits (listed above) — assess each: benign or risky?\n"
+    "3. Give a one-line recommendation.\n\n"
+    "Respond in exactly this format:\n\n"
+    "## Summary\n"
+    "[2-4 sentences]\n\n"
+    "## Security Flags\n"
+    "[Bulleted list with file references, or \"None detected\"]\n\n"
+    "## Pattern Scan Assessment\n"
+    "[For each automated scan hit (group similar hits): BENIGN or RISK — one-line reason]\n\n"
+    "## Recommendation\n"
+    "MERGE SAFE / REVIEW NEEDED / DO NOT MERGE — [one sentence reason]"
+)
+
+payload = {
+    "model": "claude-haiku-4-5-20251001",
+    "max_tokens": 2048,
+    "messages": [{"role": "user", "content": prompt}]
+}
+
+api_key = os.environ.get('ANTHROPIC_API_KEY')
+if not api_key:
+    review = "Warning: ANTHROPIC_API_KEY not set — AI review skipped. Review the diff manually before merging."
+else:
+    req = urllib.request.Request(
+        'https://api.anthropic.com/v1/messages',
+        data=json.dumps(payload).encode(),
+        headers={
+            'x-api-key': api_key,
+            'anthropic-version': '2023-06-01',
+            'content-type': 'application/json'
+        }
+    )
+    try:
+        with urllib.request.urlopen(req) as resp:
+            result = json.loads(resp.read())
+            review = result['content'][0]['text']
+    except Exception as e:
+        review = "Warning: Error generating AI review: {}\n\nReview the diff manually before merging.".format(e)
+
+# prepend scan hits so they're visible even if the AI summary is brief
+output = review
+if scan_findings:
+    output = (
+        "## Raw Pattern Scan Hits\n"
+        + "\n".join(scan_findings)
+        + "\n\n---\n\n"
+        + review
+    )
+
+with open('/tmp/ai_review.md', 'w') as f:
+    f.write(output)
+print(output)