Solves AlmaLinux/mirrors#1143 #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if SELinux is enabled during Ansible deploying - PEP8 (long lines, indents, typing etc.) - The unused import are removed, the rest imports are optimized - Get right major version if a full version is not listed in duplicated versions (the main issue) - Old field `versions_arches` is removed from the service config. Field `arches` provides the full compatibility with it
gost-serb
approved these changes
Dec 5, 2024
utils.py
Outdated
| return True | ||
| elif version in versions_arches and arch in versions_arches[version]: | ||
| elif version in arches and arch in arches[version]: |
There was a problem hiding this comment.
Suggested change
| elif version in arches and arch in arches[version]: | |
| if arch in arches[version]: |
We already made sure that version is in arches
utils.py
Outdated
| return True | ||
| elif version in versions_arches and arch in versions_arches[version]: | ||
| elif version in arches and arch in arches[version]: | ||
| return True | ||
| else: |
There was a problem hiding this comment.
No need for else. return False will do the same
jonathanspw
reviewed
Dec 10, 2024
| duplicated_versions: dict[str, str] = field(default_factory=dict) | ||
| vault_versions: list[str] = field(default_factory=list) | ||
| versions_arches: dict[str, list[str]] = field( |
There was a problem hiding this comment.
Per our chat, this is fine for the 10-beta but it removes the ability to pin repo support between minor versions and architectures for optional modules. This will likely be needed for EPEL10 on v2 if we choose to rebuild it for v2 so we'll have to revisit this in the near future.
jonathanspw
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
This one LGTM, about to work on the associated PR in https://github.com/AlmaLinux/mirrors/pull/1154/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versions_archesis removed from the service config. Fieldarchesprovides the full compatibility with it