Solves AlmaLinux/mirrors#1143 #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if SELinux is enabled during Ansible deploying - PEP8 (long lines, indents, typing etc.) - The unused import are removed, the rest imports are optimized - Get right major version if a full version is not listed in duplicated versions (the main issue) - Old field `versions_arches` is removed from the service config. Field `arches` provides the full compatibility with it
gost-serb
approved these changes
Dec 5, 2024
| @@ -164,22 +166,38 @@ def get_mirror_list( | |||
|
|
|||
| # protocol get arg | |||
| request_protocol = request.args.get('protocol') | |||
| if request_protocol and request_protocol not in ["http","https"]: | |||
| return "Invalid input for protocol, valid options: http, https" | |||
| if request_protocol and request_protocol not in ['http', 'https']: | |||
There was a problem hiding this comment.
Wouldn't
Suggested change
| if request_protocol and request_protocol not in ['http', 'https']: | |
| if request_protocol not in ['http', 'https']: |
do the same?
There was a problem hiding this comment.
No. Because we return any mirrors if request_protocol is None
jonathanspw
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versions_archesis removed from the service config. Fieldarchesprovides the full compatibility with it