[TACHYON-442] Apply PluginManagement to cleanup pom.xml in each module #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move unnecessary reference to maven-surefire-plugin
|
Test PASSed. |
|
Test PASSed. |
Contributor
Author
There was a problem hiding this comment.
The groupdId of a child pom is by default inherited from its parent pom. Before this PR, in our code some poms have defined the groupId (which is unnecessary anyway), while some other poms haven't. So in this PR, I just cleanup the poms by removing this redundant definitions to keep pom files consistent.
Contributor
|
+1 LGTM, much cleaner than before. |
haoyuan
added a commit
that referenced
this pull request
May 19, 2015
[TACHYON-442] Apply PluginManagement to cleanup pom.xml in each module
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tachyon.atlassian.net/browse/TACHYON-442
Further cleanup the pom files, focusing on maven-surefire-plugin and maven-compiler-plugin.