I 888 mean auto

[AndreasLMeg]

• Mode mean: now supports AutoGain (on/off), AutoExposure (on/off) and different values for day and night
• The mean value can also be defined differently for day and night.

[EricClaeys]

@andreaous. Do you want me to approve this PR?

[AndreasLMeg]

@EricClaeys @linuxkidd - I would be very grateful if you could do a review, test and approve

[EricClaeys]

@AndreasLMeg
In config.sh.repo, can you add "-daymean 0.3" to line 69?

capture_RPiHQ.cpp:
Lines 1067 and 1073 set myModeMeanSetting.mode_mean = true. What if the user has -nightmean set but not -daymean (or vice versa?) Where is myModeMeanSetting.mode_mean set to false? Possibly lines 1067 and 1073 should be deleted and myModeMeanSetting.mode_mean set to true or false where the "current" variables are set, like "currentAutoExposure = asiDayAutoExposure;"?
Minor: on lines 1344 and 1347 in capture_RPiHQ.cpp, "Set" should be "Sets". On line 1347, delete "-day".
Lines 1537-1541. Can these only be displayed if either day or night mean (or both) is set? I've been trying to not add log entries for things that don't apply, for example, on ZWO I don't display the cooling temperature for cameras that don't support cooling, since it doesn't apply.

mode_RPiHQ_mean.h:
Line 5: "-mean-value-day" should be "-daymean" ?
Line 16: "exposureis" should be "exposure is".
Line 28: Should there be a default "dayMean" ?

mode_RPiHQ_mean.cpp:
Line 2: "-mean-value-day" should be "-daymean" ?
Line 278 casts exposure_us and US_IN_SEC to "(double)" but line 270 doesn't. Does that matter?
Line 273 used "(double)" but line 281 doesn't.

[EricClaeys]

@AndreasLMeg, @linuxkidd,
I haven't had a chance to test yet. I've been on the road for a week and my Pi is currently is a box. I hope to have it working again in a day or two.

[AndreasLMeg]

@EricClaeys Thank you very much for the review !

With the next commit:

• minor changes: done
• I know I used too much casts - because I'm not sure everytime what the system does... (in the future I will make unittests)
• some defaults for mode mean are defined (nightMean, p0, p1, p2, threshold)
  ** If no parameter is used mode mean is deactive and you won't get the info about the parameter
  ** if any of the parameters are used (extra parameter): mode mean is active (other parameters have default values)
  ** if no dayMean is defined, this value is set to nightMean

[AndreasLMeg]

sorry make such a mess - but you can use "Squash" to merge this PR

[EricClaeys]

@AndreasLMeg Can you walk me through what happens if someone only wants to use the meanmode at night or during the day? Will the code handle that? What variable(s) would they set?
I think we need to allow for that and I would suggest that setting -nightmean turn it on for night only and -daymean turn it on only for daytime.

[EricClaeys]

@AndreasLMeg If modemean is set, how is that different from auto exposure? I assume we are allowing auto exposure without modemean, and modemean without auto exposure? If true, we'll need to document what the differences are.

[AndreasLMeg]

@EricClaeys I hope this will explain

I didn't do or adjust the old behavior.
And I won't put any energy into it either, otherwise there will certainly be issuse "I had allsky running for 5 years without any problems and now nothing works anymore - such a bad program....."

[EricClaeys]

@AndreasLMeg
Shouldn't the two blue items be "(0.5, exposure change only)" and "(05, exposure and gain change)" respectively?

I am testing this code now and will let it go overnight and tomorrow during the day.
I think we need to implement max auto-exposure for day and night like the ZWO has - I have my night exposure set to 25 seconds and the algorithm won't increase it past that. It should go up to the max auto exposure values. We can do that after this PR is done.

[AndreasLMeg]

Shouldn't the two blue items be "(0.5, exposure change only)" and "(05, exposure and gain change)" respectively?

Oh yes, copy paste mistake, sorry.

[EricClaeys]

Hi @AndreasLMeg In cases where either day or night ModeMean is on but not both, where in the code is it turning it on and off?

[EricClaeys]

@AndreasLMeg I believe the "==" on line 446 in capture_RPiHQ.cpp should be "!=". If we're doing any ModeMean'ing we want a short --timeout. The way it is now, we only get the short timeout if mean_auto is off.

[AndreasLMeg]

Hello Eric, if some mean paramameters are defined Mode mean is activ. Depending on AUTO values the MEAN_AUTO_MODE is set. https://github.com/AndreasLMeg/allsky/blob/1d01cf30260c37fe13441b2e09f17b6c8a80ff13/src/capture_RPiHQ.cpp#L1636 typedef enum {     MEAN_AUTO_OFF = 0,         // defined exposure and gain is used     MEAN_AUTO,             // changes exposure between 1us and defined exposure, and gain between 1 and defined gain     MEAN_AUTO_EXPOSURE_ONLY,     // changes exposure between 1us and defined exposure, and defined gain is used        MEAN_AUTO_GAIN_ONLY         // changes gain between 1 and defined gain, and defined exposure is used } MEAN_AUTO_MODE; // check and set mean_auto if (autoGain && autoExposure) currentModeMeanSetting.mean_auto = MEAN_AUTO; else if (autoGain) currentModeMeanSetting.mean_auto = MEAN_AUTO_GAIN_ONLY; else if (autoExposure) currentModeMeanSetting.mean_auto = MEAN_AUTO_EXPOSURE_ONLY; else currentModeMeanSetting.mean_auto = MEAN_AUTO_OFF;  

[AndreasLMeg]

@AndreasLMeg I believe the "==" on line 446 in capture_RPiHQ.cpp should be "!=". If we're doing any ModeMean'ing we want a short --timeout. The way it is now, we only get the short timeout if mean_auto is off.

I have to check this - it's so far away....

[EricClaeys]

@AndreasLMeg We can add the maxexposure values in a separate PR. We'll also need to update the settings_RPiHQ.json and camera_options_RPiHQ.json in allsky-portal to include the options, then remove the comment about -daymean and -nightmean from config.sh.