Remove leading zeros #954
Merged
Remove leading zeros #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting a string to a number, if the string begins with a 0, it's treated as an octal number. Unfortunately, if the THIS_TEMPERATURE variable is "09" that gives an error when converted to integer since 9 is not a legal octal number. I couldn't find anyway around this. I will also change capture.cpp to not add a leading 0, but it's possible a user script stores numbers with a leading 0 in tmp/temperature.txt.
Also, don't specify a number length, because without a leading zero we may get " 9" with a leading space, which is even worse!
AndreasLMeg
reviewed
Jan 21, 2022
AndreasLMeg
approved these changes
Jan 21, 2022
|
@AndreasLMeg Do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash treats numbers with a leading 0 as octal, so if we try to convert the string "09" to an integer it'll complain that "9" isn't an octal number. So, don't pass numbers to saveImage.sh with leading zero's. If saveImage.sh or another script want a fixed length number, it can create it in the desired format. For example, "9" can be converted to "09".
This bug breaks anyone with dark images taken when the sensor is either 8 or 9 degrees (which happened).