Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postData.sh: fix inaccuracy #887

Merged
merged 2 commits into from
Jan 7, 2022
Merged

postData.sh: fix inaccuracy #887

merged 2 commits into from
Jan 7, 2022

Conversation

EricClaeys
Copy link
Collaborator

Use the user Angle instead of "civil" twilight which assumes an angle of -6.
Copy the data.json file to the website on the Pi, if it exists. This is needed so the local website knows when daylight is and can display the aurora forecast picture if daytime images are not being taken.
Warn the user if their angle results in an unknown sunset time from sunwait.
Warn the user if there is no local website and no remote host to copy the file to.
Improve comments.

Use the user Angle instead of "civil" twilight which assumes an angle of -6.
Copy the data.json file to the website on the Pi, if it exists.  This is needed so the local website knows when daylight is and can display the aurora forecast picture if daytime images are not being taken.
Warn the user if their angle results in an unknown sunset time from sunwait.
Warn the user if there is no local website and no remote host to copy the file to.
Improve comments.
@EricClaeys EricClaeys added bug Needs software change config labels Jan 6, 2022
adding sunrise time allows website to know if it's daytime or nighttime.
Copy link
Collaborator

@AndreasLMeg AndreasLMeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, no testing

@EricClaeys EricClaeys merged commit a75b9af into master Jan 7, 2022
@EricClaeys EricClaeys deleted the postData.sh branch January 7, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs software change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants