Capture_RPiHQ changes #809
Conversation
Remove unneeded Log() entries. Remove unneeded comments. Check for failed capture. Fix bug where RPiHQcalcMean() was called before first picture. Fixed the "kill" command. Removed commented-out block that will never be used. Simplified building of raspistill command line. Minor tweaks.
It was actually saturation all along.
Removed unneeded Log entries. Minor spacing corrections. Finished replacing "gamma" with "saturation". Finished using c() function. Finished supporting preview. Finished supporting return code from capture.
Moved it up so it could be used by mode_RPiHQ_mean.cpp
*** Best to view changes without showing whitespace. Changed spaces to tabs. Use US_IN_SEC instead of 1000000. Changed indentation.
Needed to define it in mode_RPiHQ_mean.cpp
Use the Log() function. Moved focus stuff into get_focus_measure() - it'll eventually be used by the ZWO code. Used US_IN_SEC rather than 1000000
Per Andreas, it was for testing and isn't needed.
accidently had it killing libcamera-still
|
@EricClaeys Please don't forget to change config.sh |
|
@AndreasLMeg for your "don't forget to change config.sh" comment, are you suggesting we make the default be to use the algorithm, i.e., change CAPTURE_EXTRA_PARAMETERS to include |
@EricClaeys: I just want to have changed the comment "--mean-value..." from "-mean-value..." |
|
just did a commit to fix the extra "-" in "--mean-mode". |
|
my thoughts on allsky software, cameras, settings, ... and the future ;-) |
|
@AndreasLMeg, @ckuethe, @linuxkidd, and I plan to merge all the configuration files (config.sh, ftp_settings.sh, settings_*.json) into a single .json file, which will simplify your diagram a little. The WebUI would still be the preferred way to modify that file. That file will also allow for multiple cameras with some common settings and many per-camera settings. Hopefully this will be one of the first things we tackle after 0.8.5 is out. We've also talked about using ASCOM or INDI to make it easier to support other cameras. I'd expect that to be a longer-term effort. In the meantime I agree we should try to merge the ZWO and RPiHQ capture files, or at the least, move many of the common functions to separate .cpp files that both capture programs can use. Another thing on our list is the ability to list the "modules" that should be executed after an image is taken, for example, cropping, stretching, etc. This would be more generic than what's available today, and would more easily allow future modules like meteor detection and text/image overlays. |
Many changes to bring it closer to the ZWO version, fix a few bugs, remove some unneeded code, and others.