Keogram fixes and other changes #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also combined a few lines that were short.
Only push the appropriate quality parameters (.png or .jpg), not both. Remove setting debug based on ALLSKY_DEBUG_LEVEL - the user can use $KEOGRAM_EXTRA_PARAMETERS if they want to set the debug level. Replaced more space with tabs.
read_file() reads a file and does basic error checking. It's used initially to read the 1st file to set the now-global "nchan". It's also used to read each file.
Keep track of width of the number of images (e.g., 1000 images is a width of 4 when displayed) so the output is a consistent width. Have thread numbers appear as 1 - 4 rather than 0 - 3. Each thread no longer sets "nchan" since it's set globally before the threads run.
No reason to display the rotation angle since it's used for every image and is in config.sh. Output argument looking at for debugging (requires level 3). Combined some lines to make it easier to read. A couple spaces to tabs.
Fixed crash when size of image is different than other images - don't need to use "-s" option for this - it uses the 1st image as the baseline. Made some variables global. Moved some verbose printing into read_file(). Tell user when files are ignored. Changed verbose level of some messages - warnings of bad files are level 1. More verbose are 2 and above. -f sets "nchan" instead of "fixed_channel_num". The functionality is the same. Only use the 1st image if "nchan" and "width/height" aren't specified on the command line.
linuxkidd
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.