quote all args #617
Merged
quote all args #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxkidd
reviewed
Oct 9, 2021
| @@ -94,14 +94,14 @@ else # sftp/ftp | |||
| [ "${LFTP_COMMANDS}" != "" ] && echo ${LFTP_COMMANDS} | |||
| # xxx TODO: escape double quotes in PASSWORD - how? With \ ? | |||
| P="${PASSWORD}" | |||
| echo open --user "\"${USER}\"" --password "\"${P}\"" "${PROTOCOL}://${HOST}" | |||
| echo "open --user '${USER}' --password '${P}' '${PROTOCOL}://${HOST}' " | |||
There was a problem hiding this comment.
We should move away from $USER -- this is a reserved environment variable that is set to the logged in user's name.
Maybe:
UPLOAD_USER
UPLOAD_PASS
?
There was a problem hiding this comment.
or REMOTE_USER / REMOTE_PASS
linuxkidd
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.