Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo, improve warning message #584

Merged
merged 5 commits into from
Oct 7, 2021
Merged

fix typo, improve warning message #584

merged 5 commits into from
Oct 7, 2021

Conversation

EricClaeys
Copy link
Collaborator

No description provided.

src/capture.cpp Outdated Show resolved Hide resolved
@linuxkidd
Copy link
Collaborator

linuxkidd commented Oct 7, 2021

The code looks fine, but there still appear to be some minor spacing issues. At least, in the web UI review of the diff's. I think we can approve this, then deal with re-spacing ( via tabs ) in another PR.

I'll leave the final merge decision to @EricClaeys or @ckuethe

@ckuethe
Copy link
Collaborator

ckuethe commented Oct 7, 2021

Ship it.

Copy link
Collaborator

@ckuethe ckuethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. You can merge it after fixing the two typos I highlighted.

src/capture.cpp Show resolved Hide resolved
src/capture.cpp Outdated Show resolved Hide resolved
src/capture.cpp Outdated Show resolved Hide resolved
@EricClaeys
Copy link
Collaborator Author

Consecutive errors is correct. When a successful image is taken it sets numErrors = 0;

@ckuethe ckuethe merged commit 2998a47 into master Oct 7, 2021
@ckuethe ckuethe deleted the captureTypo branch October 7, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants