Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tool to generate notification images #569

Closed
wants to merge 9 commits into from
Closed

A tool to generate notification images #569

wants to merge 9 commits into from

Conversation

ckuethe
Copy link
Collaborator

@ckuethe ckuethe commented Oct 5, 2021

Based on #565.

  • Changed the camera-off-during-day background color to keep it consistent with the others.
  • Made the error-see-logfile all use 72pt rather than 128+72pt because it was easier to code.
  • Changed the image size to 959x719 so that they are easier to detect in case someone is using 960x720 captures.

Adding the generated output to this PR so that the output can be reviewed.

Thoughts?

Based on #565. I changed the camera-off-during-day background color to
keep it consistent with the others.

Also made the error-see-logfile all use 72pt rather than 128+72pt because
it was easier to code.
So that the output can be reviewed too.
* wrap variables in braces and double-quotes
* improve usage message
* actually use $EXTS for the reason I created it
* consistent capitalization of "Allsky Software"
@ckuethe
Copy link
Collaborator Author

ckuethe commented Oct 5, 2021

Here's a question, and I don't have a strong opinion either way:

  • do we want to "compile" the notification images as part of the build?
  • do we want to include the images in the repo and regenerate them as necessary (probably rarely)?

Copy link
Collaborator

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow Chris, you're good. If I mention that my house needs painting, will you be there this afternoon to do it?

Don't we want to delete the notification images from GitHub, and create them on the fly by having install.sh call the new script?

If you change the message of the Error image to this, you can use font size 110:
ERROR:\nSee \n/var/log/allsky.log\nfor information

I'd like to use this to make the "NoThumbnails.png" file used by allsky-website.
Can the function become a separate script that would be called the install scripts for allsky and allsky-website?
IM_SIZE, EXTS, and SW should be able to be optionally specified on the command line.

Message: No thumbnail, size: 200x167, text color: #fff600, no stroke. Ariel regular, 30pt. Background: #000000, with a 1px border of color #fff600. Only a .png file.

@EricClaeys
Copy link
Collaborator

I suggest we remove the images from GitHub and create them as part of the installation via the ~/allsky/install.sh script. This is assuming it doesn't take a really long time (more than a couple minutes?) to do so on a Pi 3.
I know we're thinking of INCLUDING the capture, keogram, and startrails programs so users don't need the whole development environment, but in the case of the Notification Images, they already need ImageMagick.

If we document how users can change the images, creating the images during installation would allow users to change them if, for example, they have a much larger or smaller sensor and want the Notification Images to match the sensor size.

@EricClaeys
Copy link
Collaborator

Just thinking, should the check for ImageMagick (and other necessary packages) go in the ~/allsky/install.sh script?

@ckuethe
Copy link
Collaborator Author

ckuethe commented Oct 5, 2021

Given enough money, I could probably find someone come by to paint it. I don't think you'd like the price though.

This script is fast. A few seconds. We can delete the images from the repo after 0.8.5.

The build/install process should have a way to check for dependencies, eg. imagemagick, lighttpd, gcc, build-essential, ... but that's a different diff.

@ckuethe ckuethe requested a review from EricClaeys October 5, 2021 22:36
@ckuethe
Copy link
Collaborator Author

ckuethe commented Oct 5, 2021

The thumbnail thing will take a little longer to figure out a good way to do that.

Copy link
Collaborator

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris, can the font size for "Error" be 110? 128 is a little too wide and the first and last character a slightly cut off.

Copy link
Collaborator

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I thought we were going to use tabs in files, not spaces. This change converts the tabs to spaces.

@EricClaeys
Copy link
Collaborator

Closing since we implemented a modified version of this tool that has additional features.

@EricClaeys EricClaeys closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants